Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] [PENDING #8635] renamed: compiler.nimble -> compiler/compiler.nimble #8636

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Aug 14, 2018

pending #8635 which introduces hierarchical modules, it now makes more sense to nest compiler.nimble so we have these:
CC: compiler.pragmas
instead of these:
CC: compiler.compiler.pragmas

pretty much everything else is like that (foo/foo.nimble instead of foo.nimble)

  • TODO:address this failure:
the command "nim e tests/test_nimscript.nims" exited with 0.
$ nimble install zip -y
     Error: Incorrect .nimble file: /home/travis/build/nim-lang/Nim/nimroot.nimble does not contain a version field.

…y a nimble package (avoids nimroot.tests.testament.tester being uncovered now that compiler.nimble was moved)
@GULPF
Copy link
Member

GULPF commented Aug 15, 2018

Pretty sure that this change would mean that repo isn't a valid Nimble package anymore. Note that the compiler can currently be installed as a library using Nimble.

@dom96
Copy link
Contributor

dom96 commented Aug 16, 2018

Nimble now supports packages which are not in the repo root, so this file could be moved.

The packages.json file just needs to be updated. Unfortunately this creates a problem: installing an older version of the compiler package will fail since it's going to look in the wrong place for the .nimble file :(

@timotheecour timotheecour reopened this Sep 1, 2018
@timotheecour timotheecour changed the title [PENDING #8635] renamed: compiler.nimble -> compiler/compiler.nimble [TODO] [PENDING #8635] renamed: compiler.nimble -> compiler/compiler.nimble Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants