Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate accumulateResult => sequtils.toSeq #8666

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

timotheecour
Copy link
Member

@dom96 @skilchen
revived from #8182 which I can't reopen (I don't have sufficient priviledges) now that I fixed #7187 which was blocking this deprecation

@timotheecour timotheecour force-pushed the pr_deprecate_accumulateResult branch from 33a5f9a to 8bc97d8 Compare October 10, 2018 21:09
@timotheecour
Copy link
Member Author

/cc @Araq ping

@timotheecour timotheecour reopened this Oct 11, 2018
@dom96 dom96 requested a review from Araq October 11, 2018 19:32
@timotheecour timotheecour reopened this Oct 11, 2018
@timotheecour
Copy link
Member Author

keep getting "job exceeded time limit", that's why i keep closing / reopening

@Araq
Copy link
Member

Araq commented Oct 11, 2018

Fine with me, but please don't make strutils import sequtils for the better variant in an upcoming PR...

@timotheecour
Copy link
Member Author

Fine with me, but please don't make strutils import sequtils for the better variant in an upcoming PR...

sure

@Araq Araq merged commit ef82076 into nim-lang:devel Oct 13, 2018
@timotheecour timotheecour deleted the pr_deprecate_accumulateResult branch October 13, 2018 07:35
krux02 pushed a commit to krux02/Nim that referenced this pull request Oct 15, 2018
narimiran pushed a commit to narimiran/Nim that referenced this pull request Oct 31, 2018
narimiran pushed a commit to narimiran/Nim that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sequtils.toSeq produces the sequence from the iterator twice if compiles(iter.len) == true
2 participants