Add jsheaders #56
Merged
Add jsheaders #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
src/fusion/js/jsheaders.nim
Outdated
| when not defined(js) and not defined(nimdoc): | ||
| {.fatal: "Module jsheaders is designed to be used with the JavaScript backend.".} | ||
|
|
||
| type Headers* = ref object ## HTTP Headers for the JavaScript target. |
There was a problem hiding this comment.
- I think this should be
ref object of JsRoot - we also need to fix similar errors in stdlib:
lib/js/dom.nim:1213:28: TouchList* {.importc.} = ref object of RootObj
lib/js/dom.nim:1293:26: TimeOut* {.importc.} = ref object of RootObj
lib/js/jsconsole.nim:16:17:type Console* = ref object of RootObj
lib/js/jsffi.nim:87:15: JsObject* = ref object of JsRoot
lib/js/jsffi.nim:89:27: JsAssoc*[K: JsKey, V] = ref object of JsRootPR's welcome!
There was a problem hiding this comment.
I was thinking it was correct because stdlib uses it, maybe documentation needs to be more explicit on that. 🤔
Too bad theres not a Linter for that.
There was a problem hiding this comment.
timotheecour
approved these changes
Dec 19, 2020
ringabout
reviewed
Dec 21, 2020
ringabout
reviewed
Dec 21, 2020
timotheecour
approved these changes
Dec 21, 2020
Merged
timotheecour
approved these changes
Dec 26, 2020
|
@juancarlospaco ok, can you find another reviewer to get a 2nd LGTM so we can merge this? |
ringabout
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsheadersmodule forHeadersfor the JavaScript target.See Add jsxmlserializer Nim#16339 (comment) and Add jsxmlserializer Nim#16339 (comment) and Add jsxmlhttprequest #57 (comment) and Add jsheaders #56 (comment) and Add jsxmlserializer #55 (comment)
and Add jsform #58 (comment)