Add jssets #59
Merged
Add jssets #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func getFloat*(this: JsSet): seq[float] {.importjs: """ | ||
| (() => {const x = []; #.forEach(a => x.push(parseFloat(a))); return x})()""".} | ||
| ## Convert `JsSet` to `seq[float]`, all items will be converted to `float`. | ||
| func toString*(this: JsSet): seq[cstring] {.importjs: """ |
There was a problem hiding this comment.
making toString return a seq[cstring] is too surprising. Either remove this or implement $(this: JsSet): string (string intended, not cstring), that would behave similar to stdlib
There was a problem hiding this comment.
@juancarlospaco this was marked as resolved but the problem is still there.
Same remark as @Araq's comment here nim-lang/Nim#16409 (comment) except this is worse because it returns a seq[cstring]
|
@juancarlospaco you're re-requesting a review but #59 (comment) is still un-addressed still fails, and my review comment says how you can easily fix it |
timotheecour
approved these changes
Dec 31, 2020
ringabout
reviewed
Jan 1, 2021
ringabout
reviewed
Jan 1, 2021
ringabout
reviewed
Jan 1, 2021
ringabout
approved these changes
Jan 1, 2021
Co-authored-by: flywind <43030857+xflywind@users.noreply.github.com>
|
@timotheecour Ping. Also #55 (review) |
timotheecour
approved these changes
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setfor the JavaScript target https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SetSee nim-lang/Nim#16339 (comment) and nim-lang/Nim#16339 (comment) and #57 (comment) and #56 (comment) and #55 (comment)
and #58 (comment)