Improve version management of nim by nimble #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyoncho
force-pushed
the
auto-nim
branch
3 times, most recently
from
50b5d18 to
0c31f6f
Compare
The following algorithm is implemented: 1. Use --nim param if specified(no validation of the version) 2. Use develop version if present(no validation of the version) 3. Use locked nim 4. Use global version if matches `require` section 5. Download and install matching version of `requires` specification does not match the existing one
tersec
reviewed
Aug 23, 2023
tests/tnonim.nim
Outdated
| # Copyright (C) Dominik Picheta. All rights reserved. | ||
| # BSD License. Look at license.txt for more info. | ||
| # # Copyright (C) Dominik Picheta. All rights reserved. | ||
| # # BSD License. Look at license.txt for more info. |
|
lgtm - in future versions we might want to use a precompiled version and / or not compile tooling (which makes the build take much longer) but those are orthogonal concerns |
arnetheduck
approved these changes
Nov 16, 2023
2 tasks
|
one side effect of the tooling being built is that another nimble is built too - depending on PATH settings, this may interfere with the nimble that the user is currently using - that's something to consider for commands that create shells |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following algorithm is implemented:
the version)
requiresectionrequiresspecification does notmatch the existing one