Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nimble from nim compilation #1175

Closed
arnetheduck opened this issue Jan 8, 2024 · 0 comments · Fixed by #1233
Closed

Remove nimble from nim compilation #1175

arnetheduck opened this issue Jan 8, 2024 · 0 comments · Fixed by #1233

Comments

@arnetheduck
Copy link

As of #1131, nimble can build nim - however, as part of building nim-the-compiler, it also builds a toolchain including nimble - this can lead to the user instance of nimble being replaced with the version that gets compiled with nim.

when nimble installs nim as part of the dependencies of a project, it should not compile nimble and other tooling as this makes nimble shell and similar behave inconsistently as nimble gets replaced by a different version.
jmgomez added a commit to jmgomez/nimble that referenced this issue Jul 4, 2024
@jmgomez
Remove nimble from nim compilation Fixes nim-lang#1175
72d9879
@jmgomez jmgomez mentioned this issue Jul 4, 2024
Merged
6 tasks
@Araq Araq closed this as completed in #1233 Jul 4, 2024
Araq pushed a commit that referenced this issue Jul 4, 2024
@jmgomez
Improves nim installation by using csources (same as atlas) (#1233)
fa09e48 
* draft: improves nim installation by using csources (same as atlas)

Notice when SAT is enabled, csources is stored in the cache.
Missing:
-- Proper reporting
-- Handle special versions (assume csources_2?). We could have special cases for #version-x
- Refactor to another file (nimble.nim is crazy big already)

* progress

* refactor: extract file nimenv

* Fixes an issue where the packageCache wasnt being shared in local mode

* [Green]Should be able to install different Nim versions

* fix warnings

* missing display

* fix typo

* Remove nimble from nim compilation Fixes #1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improves nim installation by using csources (same as atlas) jmgomez/nimble
1 participant
@arnetheduck