Improves nim installation by using csources (same as atlas) #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice when SAT is enabled, csources is stored in the cache. Missing: -- Proper reporting -- Handle special versions (assume csources_2?). We could have special cases for #version-x - Refactor to another file (nimble.nim is crazy big already)
jmgomez
changed the title
Araq
reviewed
Jul 4, 2024
| #TODO We could test special against the special versionn-x branch to get the right csources | ||
| if nimVersion.isSpecial or (major == 1 and minor >= 9) or major >= 2: | ||
| # already uses csources_v2 | ||
| "csources_v2" |
There was a problem hiding this comment.
More future proof would be:
if major >= 3: "csources_v" &$major
But it's also somewhat risky to predict the future this far.
There was a problem hiding this comment.
ok but It's an easy enough change to do when csources is increased as there is a test already that uses it in the nimble ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice when SAT is enabled, csources is stored in the cache.
Missing: