Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update docs following read-through #2930

Merged
merged 17 commits into from
Jan 26, 2023
Merged

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

This PR goes through all of the documentation except for the API docs. I have made sure that all workflow graphs are generated, but not that the docstrings match the function signatures. I did add type annotations to the init_*_wf() functions to improve that, at least.

This is pretty wide-ranging and addresses all warnings from Sphinx.

This does not change the theme, as the sphinx-immaterial theme I was considering made the API page unusable. That should be done more thoughtfully in a separate PR.

Documentation that should be reviewed

All of it.

@effigies effigies added this to the 23.0.0 milestone Jan 10, 2023
@effigies effigies requested a review from mgxd January 26, 2023 14:12
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but overall this was much needed 👍

README.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/workflows.rst Outdated Show resolved Hide resolved
@effigies
Copy link
Member Author

@mgxd Rebased rather than amend the merge commit. Full diff incorporating your suggestions: https://github.com/nipreps/fmriprep/compare/5bf536c5cc1d96bf391080228ebec6ee97c95b79..54410e8fda975fb3895e9ea2a0469b8cf68c921c

@mgxd mgxd merged commit 689ad26 into nipreps:master Jan 26, 2023
@effigies effigies deleted the doc/cleanup branch January 26, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (To be released)
Development

Successfully merging this pull request may close these issues.

2 participants