-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update docs following read-through #2930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but overall this was much needed 👍
Normalized to sentence casing (was haphazard). Removed some string breaks ("x" " y" -> "x y"). Updated some language for clearer reading in usage.html
Improve the documentation for some wrapper args
Update example figures, clarify BBR workflows, and use BIDS layout to describe FreeSurfer processing. DOC: Dedent lists to avoid block quoting
@mgxd Rebased rather than amend the merge commit. Full diff incorporating your suggestions: https://github.com/nipreps/fmriprep/compare/5bf536c5cc1d96bf391080228ebec6ee97c95b79..54410e8fda975fb3895e9ea2a0469b8cf68c921c |
Changes proposed in this pull request
This PR goes through all of the documentation except for the API docs. I have made sure that all workflow graphs are generated, but not that the docstrings match the function signatures. I did add type annotations to the
init_*_wf()
functions to improve that, at least.This is pretty wide-ranging and addresses all warnings from Sphinx.
This does not change the theme, as the sphinx-immaterial theme I was considering made the API page unusable. That should be done more thoughtfully in a separate PR.
Documentation that should be reviewed
All of it.