Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Preserve pixdim4+ of resampled images #3239

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

effigies
Copy link
Member

Closes #3216.

@effigies effigies added this to the 23.2.1 milestone Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.34%. Comparing base (b8d6af3) to head (d0dc360).
Report is 1 commits behind head on maint/23.2.x.

Files Patch % Lines
fmriprep/interfaces/resampling.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maint/23.2.x    #3239      +/-   ##
================================================
- Coverage         72.36%   72.34%   -0.02%     
================================================
  Files                55       55              
  Lines              4103     4104       +1     
================================================
  Hits               2969     2969              
- Misses             1134     1135       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

@mgxd @oesteban I think this should be a quick review.

@oesteban
Copy link
Member

oesteban commented Feb 29, 2024 via email

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder where this divergence is occuring...

@effigies effigies merged commit 009cb93 into nipreps:maint/23.2.x Feb 29, 2024
10 of 12 checks passed
effigies added a commit that referenced this pull request Mar 6, 2024
23.2.1 (March 06, 2024)

Bug fix release in the 23.2.x series.

Masks, BOLD references and T2\* maps resampled into template spaces had
their order of transforms inverted. BOLD files were unaffected.

This release also preserves the TR in the NIfTI header of BOLD series.

* FIX: Preserve pixdim4+ of resampled images (#3239)
* FIX: Flip order of transforms in ``init_ds_volumes_wf`` (#3238)
* DOCKER: restore mincinfo binary (#3249)
* CI: Move to new CircleCI machine tags (#3247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants