Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: IntraModalMerge failed for dims (x, y, z, 1) #441

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

oesteban
Copy link
Member

See nipreps/sdcflows#77.

I'll try to add a regression test for this ASAP. For now, it'd be good to have your opinion on how I'm using nibabel, Chris.

@oesteban oesteban added the bug label Dec 17, 2019
@oesteban oesteban added this to the 1.1.0 milestone Dec 17, 2019
@oesteban oesteban requested a review from effigies December 17, 2019 18:41
@pull-assistant
Copy link

pull-assistant bot commented Dec 17, 2019

Score: 0.88

Best reviewed: commit by commit


Optimal code review plan

     FIX: IntraModalMerge failed for dims (x, y, z, 1)

     fix: address @effigies' comments and add tests

Powered by Pull Assistant. Last update 797e375 ... 144cc43. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #441 into master will decrease coverage by 4.68%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   59.94%   55.25%   -4.69%     
==========================================
  Files          57       42      -15     
  Lines        5480     4852     -628     
  Branches      647      652       +5     
==========================================
- Hits         3285     2681     -604     
+ Misses       2152     2046     -106     
- Partials       43      125      +82
Flag Coverage Δ
#masks ?
#reportlettests ?
#unittests ?
Impacted Files Coverage Δ
niworkflows/interfaces/images.py 52.13% <57.14%> (-0.11%) ⬇️
niworkflows/func/util.py 28% <0%> (-52%) ⬇️
niworkflows/interfaces/fixes.py 41.17% <0%> (-45.1%) ⬇️
niworkflows/interfaces/ants.py 57.81% <0%> (-16.15%) ⬇️
niworkflows/engine/workflows.py 26.31% <0%> (-15.79%) ⬇️
niworkflows/interfaces/bids.py 80.15% <0%> (-15.48%) ⬇️
niworkflows/interfaces/utility.py 75.47% <0%> (-13.21%) ⬇️
niworkflows/utils/bids.py 75.94% <0%> (-12.81%) ⬇️
niworkflows/interfaces/itk.py 28.39% <0%> (-10.5%) ⬇️
niworkflows/interfaces/registration.py 51.72% <0%> (-10.35%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88c521...144cc43. Read the comment docs.

@oesteban oesteban merged commit b7f9955 into nipreps:master Dec 18, 2019
@oesteban oesteban deleted the fix/sdcflows-77 branch December 18, 2019 00:12
oesteban added a commit to oesteban/niworkflows that referenced this pull request Dec 18, 2019
oesteban added a commit that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants