Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiral fieldmap estimation workflow is broken #77

Closed
oesteban opened this issue Dec 17, 2019 · 0 comments · Fixed by #79
Closed

Spiral fieldmap estimation workflow is broken #77

oesteban opened this issue Dec 17, 2019 · 0 comments · Fixed by #79
Assignees
Labels
bug Something isn't working SEI - Spiral Echo Imaging
Milestone

Comments

@oesteban
Copy link
Member

oesteban commented Dec 17, 2019

@poldrack just hit this wall

Node: fmriprep_wf.single_subject_s573_wf.func_preproc_ses_1_task_DPX_run_1_wf.sdc_estimate_wf.fmap_wf.fmapmrg
Working directory: /scratch1/01329/poldrack/uh2_workdir/fmriprep_wf/single_subject_s573_wf/func_preproc_ses_1_task_DPX_run_1_wf/sdc_estimate_wf/fmap_wf/fmapmrg

Node inputs:

hmc = False
in_files = ['/scratch1/01329/poldrack/BIDS_scans/sub-s573/ses-1/fmap/sub-s573_ses-1_fieldmap.nii.gz']
to_ras = True
zero_based_avg = False

Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 69, in run_node
    result['result'] = node.run(updatehash=updatehash)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 479, in run
    result = self._run_interface(execute=True)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 585, in _run_interface
    return self._run_command(execute)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 678, in _run_command
    result = self._interface.run(cwd=outdir)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/interfaces/base/core.py", line 382, in run
    runtime = self._run_interface(runtime)
  File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/interfaces/images.py", line 83, in _run_interface
    hmcdat = hmcnii.get_fdata().mean(axis=3)
  File "/usr/local/miniconda/lib/python3.7/site-packages/numpy/core/_methods.py", line 62, in _mean
    rcount = _count_reduce_items(arr, axis)
  File "/usr/local/miniconda/lib/python3.7/site-packages/numpy/core/_methods.py", line 55, in _count_reduce_items
    items *= arr.shape[ax]
IndexError: tuple index out of range

The problem is that #52 resulted in a broken workflow for fieldmaps. I'm not sure whether this problem was inherited from the upstream PR I was based on or I introduced it. Regardless the cause, I'll be fixing this today and add one test for it.

EDIT: Actually a problem in NiWorkflows.

@oesteban oesteban added bug Something isn't working SEI - Spiral Echo Imaging labels Dec 17, 2019
@oesteban oesteban added this to the 1.1.0 milestone Dec 17, 2019
@oesteban oesteban self-assigned this Dec 17, 2019
oesteban added a commit to oesteban/niworkflows that referenced this issue Dec 17, 2019
oesteban added a commit to oesteban/sdcflows that referenced this issue Dec 18, 2019
… y, z, 1)

After revising the workflow design, everything looked good (so I stand
corrected - have scratched text accordingly in the bug report).

Just an update of niworkflows will be necessary. Replaces and closes nipreps#78.

Close nipreps#77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SEI - Spiral Echo Imaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant