ENH: Finalizing the API overhaul #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
feat/gen-workflow-from-estimation-object
branch
from
282aee2 to
d2ce402
Compare
oesteban
force-pushed
the
feat/gen-workflow-from-estimation-object
branch
from
d2ce402 to
75c4d07
Compare
Codecov Report
@@ Coverage Diff @@
## dev/1.4.0 #132 +/- ##
=============================================
+ Coverage 88.44% 91.51% +3.07%
=============================================
Files 15 17 +2
Lines 926 943 +17
Branches 109 121 +12
=============================================
+ Hits 819 863 +44
+ Misses 75 49 -26
+ Partials 32 31 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
oesteban
force-pushed
the
feat/gen-workflow-from-estimation-object
branch
2 times, most recently
from
d38cf9d to
4c41428
Compare
oesteban
force-pushed
the
feat/gen-workflow-from-estimation-object
branch
2 times, most recently
from
3ed7829 to
91ed4ff
Compare
|
Hello @oesteban, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-11-28 15:16:29 UTC |
This commit makes a deep revisiting of our total readout time implementation. Most of the relevant details about this commit are included within the documentation. With thanks to @neurolabusc because this wouldn't have been possible without his thorough work, to @parekhpravesh for the thread he opened at Neurostars, to @Gilles86 for making us aware of these issues on the *fMRIPrep* repo, and to @treanus for reporting nipreps#5. Resolves: nipreps#5.
oesteban
force-pushed
the
feat/gen-workflow-from-estimation-object
branch
from
91ed4ff to
debce89
Compare
oesteban
added a commit
that referenced
this pull request
Dec 24, 2020
2.0.0rc4 * FIX: Convert SEI fieldmaps given in rad/s into Hz (#127) * FIX: Limit ``3dQwarp`` to maximum 4 CPUs for stability reasons (#128) * ENH: Generate a simple mask after correction (#161) * ENH: Increase unit-tests coverage of ``sdcflows.fieldmaps`` (#159) * ENH: Optimize tensor-product B-Spline kernel evaluation (#157) * ENH: Add a memory check to dynamically limit interpolation blocksize (#156) * ENH: Massage TOPUP's fieldcoeff files to be compatible with ours (#154) * ENH: Add a simplistic EPI masking algorithm (#152) * ENH: Utility that returns the ``B0FieldSource`` of a given potential EPI target (#151) * ENH: Write ``fmapid-`` entity in Derivatives (#150) * ENH: Multiplex fieldmap estimation outputs into a single ``outputnode`` (#149) * ENH: Putting the new API together on a base workflow (#143) * ENH: Autogenerate ``B0FieldIdentifiers`` from ``IntendedFor`` (#142) * ENH: Finalizing the API overhaul (#132) * ENH: Keep a registry of already-used identifiers (and auto-generate new) (#130) * ENH: New objects for better representation of fieldmap estimation (#114) * ENH: Show FieldmapReportlet oriented aligned with cardinal axes (#120) * ENH: New estimation API (featuring a TOPUP implementation!) (#115) * DOC: Minor improvements to the literate workflows descriptions. (#162) * DOC: Fix typo in docstring (#155) * DOC: Enable NiPype's sphinx-extension to better render Interfaces (#131) * MAINT: Drop Python 3.6 (#160) * MAINT: Enable Git-archive protocol with setuptools-scm-archive (#153) * MAINT: Migrate TravisCI -> GH Actions (completion) (#138) * MAINT: Migrate TravisCI -> GH Actions (#137) * MAINT: Minimal unit test and refactor of pepolar workflow node (#133) * MAINT: Collect code coverage from tests on Circle (#122) * MAINT: Test minimum dependencies with TravisCI (#96) * MAINT: Add FLIRT config files to prepare for TOPUP integration (#116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.