-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Refactoring the way nipype checks Node hashes #2383
Conversation
Maybe not necessary for this release, if you guys are very busy (as I imagine), but this should simplify hashing nodes. It'd be great to hear from @satra on this. |
@oesteban - this looks good to me. |
@effigies - your call if you want to include this in 1.0. it will make the code look a lot cleaner. |
@effigies - it would be fine with me to include this. |
No objections from me, I just haven't reviewed it, myself. Feel free to merge. |
Hopefully, to make it a bit simpler. This could affect #2380.
Main ideas:
Node.is_cached()
member, trying to remove the responsibility of checking hashes from teh Plugins and putting it all in the Node context.Node.hash_value()
with the use ofis_cached()
.Node.needed_outputs
is now a property (allowing some checks when setting).get_inputs
, hash calculation,needed_outputs
calculation and the hash elements:_hashvalue
and_hashed_inputs