FIX: Change to interface workdir within Interface.run() instead Node #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added many reviewers just to make sure we are not missing out any details. |
djarecka
reviewed
Jan 19, 2018
| @@ -471,7 +480,8 @@ def run(self, **inputs): | |||
| env['DISPLAY'] = config.get_display() | |||
|
|
|||
| runtime = Bunch( | |||
| cwd=os.getcwd(), | |||
| cwd=cwd, | |||
| prevcwd=syscwd, | |||
There was a problem hiding this comment.
I couldn't find a place where this is being used
There was a problem hiding this comment.
Oh, forgot to add it to the report.rst
|
Removed the CHANGES entry: |
oesteban
added a commit
to nipreps/niworkflows
that referenced
this pull request
Jan 19, 2018
oesteban
added a commit
to nipreps/niworkflows
that referenced
this pull request
Jan 19, 2018
satra
approved these changes
Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2380 and #2368 (comment)