Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back #2

Merged
merged 17 commits into from
Jan 31, 2019
Merged

Merge back #2

merged 17 commits into from
Jan 31, 2019

Conversation

nirgfani
Copy link
Owner

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

veronicagg and others added 17 commits January 24, 2019 10:01
* fixed some invalid values in dl account examples

* adding resource group sample

* removed .

* updating script to handle output of batch processing from autorest (#5081)
* Add list and get software to GuestConfiguration

* Use newer API version for software

* Revert software Swagger spec since these are private preview only

* Add specs for software update and software profile

* Address comments for property type and proxy reference

* Address comments for softwareUpdateProfile

* Address comments for softwareUpdate
* adding ekg swagger files

* review fixes

* review fixes

* review fixes

* adding go readme file

* renaming ekg to EnterpriseKnowledgeGrapg

* renaming ekg to EnterpriseKnowledgeGrapg

* renaming ekg to EnterpriseKnowledgeGrapg

* adding metadata property

* adding metadata property

* fixing go issues
…ures. (#5094)

* Add 'br' tag and add quota description.

* Modify quota description string.

* Modify quota description string(apply).

* Add period after quota description.

* Change 。 to .
…#5107)

* Add new field 'proximityPlacementGroup' to properties of HanaInstance

* Update proximityPlacementGroup to full ARM path
* Add dispatch child to LUIS Runtime response

* fix typo
* HDFS FE: Update 2018-11-09 DataLakeStorage Swagger.

* HDFS FE: Update 2018-11-09 DataLakeStorage Swagger - Fix typo.

* HDFS FE: Update 2018-11-09 DataLakeStorage Swagger - Fix typo.

* HDFS FE: Update 2018-11-09 DataLakeStorage Swagger - Fix typo.

* fix Go SDK package path
Adding two new ManagedInstance properties
* Creating first and basic swagger for new RP of ASI (Azure Security Insight).

This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace.

This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC.

* updating the operationalInsightsResourceProvider to be a global parameter and reuse it in the PUT same as in the GET

* Fixing comments from PR

* Fixing the Microsoft.OperationalInsight to the right form

* Updating the location to be under- "resource-manager"

* adding readme files for the swagger

* Changing the path of the files to the correct path

* Change the location of the readme files

* Fixing inconsistency in the naming- changing everything to SecurityInsights

* Missed the file when aligned the name to SecurityInsights

* Fixing a redundant space in the examples

* add alertRule to the CreateAlertRule.json and do some indentation fixes

* Creates the "real" API for Scheduled Alert Rules

* Update the name alertRule to alertScheduledtRule in the creation example

* Fixing comments from PR-

* Changing durations to fit standards
* Changing operators to fit other RPs
* Align naming to scheduledAlertRules
* Adding 200 response to DeleteScheduledAlertRule

* Changing naming-

alertTriggerOperator => triggerOperator
alertTriggerThreshold => triggerThreshold

* Adding kind to AlertRule and making Scheduled as a specific kind

* Fix some errors

* Trying to solve the model validator issues

* Fixing indentation
@nirgfani nirgfani merged commit 26f94da into nirgfani:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.