Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prerender): decode urls to allow comma in the x-nitro-prerender header #799

Merged
merged 1 commit into from
Jan 3, 2023
Merged

fix(prerender): decode urls to allow comma in the x-nitro-prerender header #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/prerender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,10 @@ function extractLinks(

// Extract from x-nitro-prerender headers
const header = res.headers.get("x-nitro-prerender") || "";
_links.push(...header.split(",").map((i) => i.trim()));
_links.push(...header.split(",")
.map((i) => i.trim())
.map((i) => decodeURIComponent(i));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing a ) here:

Suggested change
.map((i) => decodeURIComponent(i));
.map((i) => decodeURIComponent(i)));

Copy link
Contributor Author

@posixpascal posixpascal Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad. Fixed it in #801. 😔



for (const link of _links.filter(Boolean)) {
const parsed = parseURL(link);
Expand Down