fix(prerender): decode urls to allow comma in the x-nitro-prerender header
#799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
x-nitro-prerender header
pi0
reviewed
Jan 3, 2023
src/prerender.ts
Outdated
| _links.push(...header.split(",").map((i) => i.trim())); | ||
| _links.push(...header.split(",") | ||
| .map((i) => decodeURIComponent(i)) | ||
| .map((i) => i.trim())); |
There was a problem hiding this comment.
I think we should move trim before decode
There was a problem hiding this comment.
Yes, good catch. I've updated the PR.
MiniDigger
reviewed
Jan 3, 2023
| _links.push(...header.split(",").map((i) => i.trim())); | ||
| _links.push(...header.split(",") | ||
| .map((i) => i.trim()) | ||
| .map((i) => decodeURIComponent(i)); |
There was a problem hiding this comment.
you are missing a ) here:
Suggested change
| .map((i) => decodeURIComponent(i)); | |
| .map((i) => decodeURIComponent(i))); |
There was a problem hiding this comment.
Oh my bad. Fixed it in #801. 😔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first timer here 🎉.
🔗 Linked issue
nuxt/image#701
❓ Type of change
📚 Description
When using
@nuxt/image-edgewith Nuxt 3 the default image provider is IPX which allows arbitrary image manipulation through URLs.When using multiple transformations on an image the different transformations are seperated by a comma like this in the final image URL:
@nuxt/image-edgeappends these URLs to theX-Nitro-Prerenderheader without encoding the URL.The header will then be split by "," when prerendering the site which leads to the following URLs being prerendered:
This results in some images not being properly prerendered and/or missing in the final output build when running
yarn run generate📝 Checklist