Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON output has mixed line endings #42

Closed
Jorteck opened this issue Dec 15, 2021 · 0 comments · Fixed by #43
Closed

JSON output has mixed line endings #42

Jorteck opened this issue Dec 15, 2021 · 0 comments · Fixed by #43

Comments

@Jorteck
Copy link
Contributor

Jorteck commented Dec 15, 2021 •
edited
Loading

Expected Behaviour
JSON output always uses LF line endings, or the correct line endings for the current platform.

Actual Result
The JSON output always ends with a single CRLF line ending. Tested on both Windows and Linux
If pretty output is on, the rest of the output uses LF line endings.

image
@Jorteck Jorteck mentioned this issue Dec 15, 2021
Merged
@niv niv closed this as completed in #43 Dec 15, 2021
squattingmonk added a commit to squattingmonk/nasher that referenced this issue Dec 20, 2021
@squattingmonk
"fix: remove json line ending carriage returns"
9b60fad 
This will be more consistent with the new behavior of neverwinter.nim
after [issue #42](niv/neverwinter.nim#42) was
fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nwn_gff: Write line ending without carriage return. jhett12321/neverwinter.nim
1 participant
@Jorteck