Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwn_gff: Write line ending without carriage return. #43

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

Jorteck
Copy link
Contributor

@Jorteck Jorteck commented Dec 15, 2021

Resolves #42

@niv
Copy link
Owner

niv commented Dec 15, 2021

I did read some comment on the nim forums where cL was deprecated/replaced with \n or \p: nim-lang/Nim#7089

If I'm reading that thread correctly, then \n is the one to use - same meaning as in C now, and the indended one here (so it fits the JSON spec).

@Jorteck
Copy link
Contributor Author

Jorteck commented Dec 15, 2021

I updated the usage in nwn_gff \n. There are also some usages of \c\L in nwn_twoda, but I presume that it's always CRLF regardless of platform.

@niv niv merged commit 147ddd2 into niv:master Dec 15, 2021
@niv
Copy link
Owner

niv commented Dec 15, 2021

Thanks! Yes, I agree - for 2da content, window-style newlines are the norm and that seems to work well. I'll transform it to \r\n at some point if it turns out to be a problem in future nim releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON output has mixed line endings
3 participants