Fix endian swap on SocketAddrV6. #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to go now. |
asomers
requested changes
Jan 12, 2023
flowinfo and scope_id should not be byte swapped.
Merged
rwestphal
added a commit
to holo-routing/holo
that referenced
this pull request
Jun 21, 2023
For multihop sessions to work, it's necessary to extract both the source and destination addresses from each received packet. Achieving this requires using lower-level APIs not directly supported by Tokio or Rust's standard library. This commit introduces the usage of the recvmsg() API from the nix crate to get that done. As result, multihop sessions now work normally. Additionally, the nix version has been updated to 0.26 to incorporate a necessary bug fix [1]. [1] nix-rust/nix#1964 Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
rwestphal
added a commit
to holo-routing/holo
that referenced
this pull request
Jan 25, 2024
For multihop sessions to work, it's necessary to extract both the source and destination addresses from each received packet. Achieving this requires using lower-level APIs not directly supported by Tokio or Rust's standard library. This commit introduces the usage of the recvmsg() API from the nix crate to get that done. As result, multihop sessions now work normally. Additionally, the nix version has been updated to 0.26 to incorporate a necessary bug fix [1]. [1] nix-rust/nix#1964 Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug. flowinfo and scope_id should not be byte swapped here.
See also #1963.