Use libc constants in sys/signal.rs. #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That allows us to import sigaction on older rust versions.
|
I like the sound of that diffstat! |
| pub sa_mask: sigset_t, | ||
| pub sa_flags: SockFlag, | ||
| bitflags!{ | ||
| flags HowFlag: libc::c_int { |
There was a problem hiding this comment.
should we rename this to SigFlags while here?
|
Other than possible renaming of flags types, r=me. This is great! |
|
📌 Commit a8e37d6 has been approved by |
homu
added a commit
that referenced
this pull request
Feb 29, 2016
Use libc constants in sys/signal.rs. Work toward #264.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work toward #264.