Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pry-nav does not work with the latest version of pry #35

Closed
cdhagmann opened this issue Sep 29, 2020 · 5 comments
Closed

pry-nav does not work with the latest version of pry #35

cdhagmann opened this issue Sep 29, 2020 · 5 comments

Comments

@cdhagmann
Copy link

Bundler could not find compatible versions for gem "pry":
In Gemfile:
pry (~> 0.13.1)

pry-nav was resolved to 0.3.0, which depends on
  pry (>= 0.9.10, < 0.13.0)
ivoanjo added a commit to DataDog/dd-trace-rb that referenced this issue Mar 12, 2021
The old `pry-nav` is basically abandoned at this point, see
<nixme/pry-nav#35> and
<nixme/pry-nav#33> and the README points to
`pry-byebug`:
<https://github.com/nixme/pry-nav#using-mri-we-recommend-pry-byebug-instead>.

Because of our usual support matrix of old Rubies, I've kept `pry-nav`
around for older versions.

I've also added `pry-debugger-jruby`, which is a nicer alternative for
JRuby.

This setup works correctly for all Rubies: 2.0 to 3.0, JRuby and even
TruffleRuby.
ivoanjo added a commit to DataDog/dd-trace-rb that referenced this issue Mar 12, 2021
The old `pry-nav` is basically abandoned at this point, see
<nixme/pry-nav#35> and
<nixme/pry-nav#33> and the README points to
`pry-byebug`:
<https://github.com/nixme/pry-nav#using-mri-we-recommend-pry-byebug-instead>.

Because of our usual support matrix of old Rubies, I've kept `pry-nav`
around for older versions.

I've also added `pry-debugger-jruby`, which is a nicer alternative for
JRuby.

This setup works correctly for all Rubies: 2.0 to 3.0, JRuby and even
TruffleRuby.
@iloveitaly
Copy link
Collaborator

@cdhagmann this is fixed on master, give it a try and let me know what you think! We'll release a new version via rubygems soon.

@makikata
Copy link

makikata commented Sep 1, 2021

@iloveitaly thank you I use it daily and it works like a charm!!! With a but ;)

I do not know which one of the repository below should I create an issue, thus commenting here as it is related. Otherwise please advise.

Based on this comment, it seems that the pry-byebug fork works with pry-remote. However it looks like combining below, breaks pry-nav.

Basically using next, or step it just skips the whole stack and goes at.

From: /home/user/.asdf/installs/ruby/3.0.1/lib/ruby/gems/3.0.0/gems/pry-remote-0.1.8/lib/pry-remote.rb:211 PryRemote::Server#run:

    206: def run
    207:   setup
    208: 
    209:   Pry.start(@object, @options.merge(:input => client.input_proxy, :output => client.output))
    210: ensure
 => 211:   teardown
    212: end

This ONLY happens if I am using pry-remote

PS: I was commenting here because I felt it has something to do with the commands sent by pry-nav

@iloveitaly
Copy link
Collaborator

@makikata are you on MRI ruby or another ruby runtime?

@makikata
Copy link

makikata commented Sep 1, 2021

@iloveitaly I am on MRI 3.0.1

EDIT: I did further testing today and it has nothing to do with pry-nav itself. Removing pry-nav from my Gemfile has the same result.

So please ignore

@iloveitaly
Copy link
Collaborator

Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants