Update pry dependency to < 0.14.0
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pry 0.13.0 is released: https://github.com/pry/pry/blob/master/CHANGELOG.md#v0130-march-21-2020 It doesn't look like `pry-nav` is using any of the deprecated or deleted functionalities.
|
It would be a huge help if we could this change merged in and new version of |
|
I have the same issue as @rrosenblum . Maybe @nixme could consider prioritising this fix? |
|
#32 might be nice to be incorporated too with the new release. |
|
Any plans on upgrading the gem? |
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Mar 12, 2021
The old `pry-nav` is basically abandoned at this point, see <nixme/pry-nav#35> and <nixme/pry-nav#33> and the README points to `pry-byebug`: <https://github.com/nixme/pry-nav#using-mri-we-recommend-pry-byebug-instead>. Because of our usual support matrix of old Rubies, I've kept `pry-nav` around for older versions. I've also added `pry-debugger-jruby`, which is a nicer alternative for JRuby. This setup works correctly for all Rubies: 2.0 to 3.0, JRuby and even TruffleRuby.
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Mar 12, 2021
The old `pry-nav` is basically abandoned at this point, see <nixme/pry-nav#35> and <nixme/pry-nav#33> and the README points to `pry-byebug`: <https://github.com/nixme/pry-nav#using-mri-we-recommend-pry-byebug-instead>. Because of our usual support matrix of old Rubies, I've kept `pry-nav` around for older versions. I've also added `pry-debugger-jruby`, which is a nicer alternative for JRuby. This setup works correctly for all Rubies: 2.0 to 3.0, JRuby and even TruffleRuby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pry 0.13.0 is released: https://github.com/pry/pry/blob/master/CHANGELOG.md#v0130-march-21-2020
It doesn't look like
pry-navis using any of the deprecated or deletedfunctionalities.