Fix/tendl pn #202
Merged
Fix/tendl pn #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Wim,
On the road between Florida and South Carolina. It'll be later this week
before I can get to this. Is that OK, or maybe someone else can step in if
you can't wait.
Skip
sent from my mobile
…On Mon, May 24, 2021, 5:50 PM Wim Haeck ***@***.***> wrote:
@whaeck <https://github.com/whaeck> requested your review on: #202
<#202> Fix/tendl pn.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#202 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHJISJVFKNZFBH2UW5EEQTTPLC3FANCNFSM45OAIHCA>
.
|
|
No worries Skip. It can wait a few days ;-) This one is also relatively simple (took longer to diagnose though). |
kahlerac
approved these changes
May 29, 2021
|
Excellent job, it does also works for numerous targets from g-tendl-2019, now producing beautiful if not always physical ace check tapes, the one below with a reconr sequence |
|
Thanks for this additional check JCS. I did the review/approval on
Saturday but it's a holiday in the US today.
Skip
sent from my mobile
…On Mon, May 31, 2021, 9:49 AM jchsublet ***@***.***> wrote:
Excellent job, it does also works for numerous targets from g-tendl-2019,
now producing beautiful if not always physical ace check tapes, the one
below with a reconr sequence
Fe056chk.pdf <https://github.com/njoy/NJOY2016/files/6570666/Fe056chk.pdf>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#202 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHJISLDMKUOSTHBHGVJ3GDTQOHVTANCNFSM45OAIHCA>
.
|
|
@kahlerac I updated the release notes, and set up a weekly schedule to run all tests from now on. No need to review these last changes. Once the tests have run, I'll merge and tag a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #201, see the issue for more information.