Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file exists for do callout #397

Merged
merged 4 commits into from
Jul 7, 2024
Merged

Conversation

jokoho48
Copy link
Collaborator

When merged, this pull request will:

  1. Possible Replacement for Check callout validity #380

It is generally slower than #380, but it does not matter because it gets cached for the benefit of fewer false discards.

@rekterakathom
Copy link
Contributor

Looks good. I think this one manages to find RHS callouts by adding the file extension, which is something that #380 can't do.

I added the .mp3 extension to #380 "just to be sure" since it didn't hurt performance, but here it might have a big impact on the worst-case performance (when all extensions are tested). Perhaps it's worth testing whether or not .mp3 is a valid format accepted by the engine at all, the biki says it is not.

@nk3nny nk3nny mentioned this pull request Jul 7, 2024
@jokoho48 jokoho48 merged commit 25abd26 into master Jul 7, 2024
4 checks passed
@jokoho48 jokoho48 deleted the use-fileExists-for-doCallout branch July 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants