Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change in fnc_doCallout #399

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

rekterakathom
Copy link
Contributor

Reverts a part of #355 because of recent discovery that files included in addons must not have a leading slash (source). Haven't verified this myself but this has basically no performance impact due to caching so might as well revert it just to be safe.

This will conflict with #380 and #397, I'll fix it when the time comes.

When merged this pull request will:

  1. Describe what this pull request will do
    Removes leading slash from callout file paths

  2. Each change in a separate line
    Removes leading slash from callout file paths

Reverts a part of nk3nny#355 because of recent discovery that files included in addons must not have a leading slash
@jokoho48
Copy link
Collaborator

jokoho48 commented Jul 7, 2024

when Merge Conflicts are resolved this can get merged

@rekterakathom
Copy link
Contributor Author

Merge conflict should be resolved now

@jokoho48 jokoho48 added this to the 2.6.1 milestone Oct 14, 2024
@jokoho48 jokoho48 merged commit 62abf80 into nk3nny:master Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants