Improve wording of parse_error exception #4037 #4073
Conversation
| @@ -479,6 +479,10 @@ class parser | |||
| error_msg += concat(m_lexer.get_error_message(), "; last read: '", | |||
| m_lexer.get_token_string(), '\''); | |||
| } | |||
| else if (last_token == token_type::end_of_input && m_lexer.get_position().chars_read_total == 1) | |||
| { | |||
| error_msg += concat("unexpected end of input, check that your input string or stream contains the expected JSON"); | |||
There was a problem hiding this comment.
That error message confuses me.
There was a problem hiding this comment.
What would you suggest, I change it to?
Also about the amalgamation checks, I run check_amalgamate on my local machine and it passes. I think it's because of astyle version difference which version should I use?
There was a problem hiding this comment.
Hi again, I'm free for a few more days, my semester starts after that, it'd be great if you could reply in the next 2-3 days, however, I'm still happy to contribute after that.
There was a problem hiding this comment.
I'm on vacation, so I cannot really help here.
There was a problem hiding this comment.
I would recommend something along the lines of "the provided input was empty, check that you are providing the expected input", so it's not just "unexpected end of input" but "the input was empty".
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @CosmicPegasis |
This pull request improves the error message for the end of input parse_error.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.Please don't
#ifdefs or other means.