Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wording of parse_error exception #4037

Closed
nlohmann opened this issue May 20, 2023 · 7 comments · Fixed by #4180
Closed

Improve wording of parse_error exception #4037

nlohmann opened this issue May 20, 2023 · 7 comments · Fixed by #4180
Labels
documentation good first issue
Milestone
Release 3.11.3

Comments

@nlohmann
Copy link
Owner 

          @nlohmann This exact error happens enough that I'm wondering if there should be a more specific error message for it, such as "Error attempting to parse an empty input, check that your input string or stream contains the expected JSON."

Originally posted by @gregmarr in #4028 (comment)
@haseeb-xd
Copy link

haseeb-xd commented May 20, 2023 •
edited
Loading

I would like to work on this, Can you please tell me where can I add new parse_error exception message.
Thanks

@nlohmann
Copy link
Owner Author

Please check the code where parse_error is thrown.

@theevilone45
Copy link
Contributor

Hey @nlohmann, can I do it? 😊

@nlohmann
Copy link
Owner Author

Hey @nlohmann, can I do it? 😊

Sure!

CosmicPegasis added a commit to CosmicPegasis/json that referenced this issue Jul 17, 2023
@CosmicPegasis
Add better end of input error message (nlohmann#4037)
63152c5
@st17931
Copy link

st17931 commented Jul 25, 2023

Is it done ?? Or i can look into it? @nlohmann

@nlohmann
Copy link
Owner Author

See #4073. It's not done yet.

@gregmarr gregmarr mentioned this issue Sep 5, 2023
Closed
@colbychaskell
Copy link
Contributor

colbychaskell commented Oct 7, 2023 •
edited
Loading

Looks like the work on this fell through... I can work on this if needed.

@colbychaskell colbychaskell mentioned this issue Oct 7, 2023
Merged
4 tasks
@nlohmann nlohmann linked a pull request Oct 31, 2023 that will close this issue
Add more specific error message when attempting to parse empty input #4180
Merged
4 tasks
@nlohmann nlohmann added this to the Release 3.11.3 milestone Oct 31, 2023
@nlohmann nlohmann mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging a pull request may close this issue.

Add more specific error message when attempting to parse empty input colbychaskell/json
5 participants
@nlohmann @theevilone45 @haseeb-xd @st17931 @colbychaskell