Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more specific error message when attempting to parse empty input #4180

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

colbychaskell
Copy link
Contributor

@colbychaskell colbychaskell commented Oct 7, 2023

Addresses #4037

Modifies the sax parser to create an exception with a more specific error message when attempting to parse an empty input string or stream.

Modifies corresponding tests to expect the new error message.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@coveralls
Copy link

coveralls commented Oct 7, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 5c22104 on colbychaskell:fix-parse-error-wording into edffad0 on nlohmann:develop.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @colbychaskell
Please read and follow the Contribution Guidelines.

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @colbychaskell
Please read and follow the Contribution Guidelines.

@nlohmann
Copy link
Owner

nlohmann commented Oct 9, 2023

Can you please try to amalgamate with an older version of astyle, like astyle 3.2? There was a breaking change in astyle which makes the output differ unfortunately.

@colbychaskell colbychaskell force-pushed the fix-parse-error-wording branch from cca9375 to 750fc47 Compare October 11, 2023 22:19
@colbychaskell
Copy link
Contributor Author

@nlohmann amalgamated with astyle 3.1 and it seems to have worked correctly now

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nlohmann nlohmann added this to the Release 3.11.3 milestone Oct 31, 2023
@nlohmann nlohmann linked an issue Oct 31, 2023 that may be closed by this pull request
@nlohmann nlohmann merged commit 59da644 into nlohmann:develop Oct 31, 2023
109 checks passed
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve wording of parse_error exception
3 participants