Experimental support for binary type and CBOR (de)serialization #862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all huge thanks for creating this library.
I saw a few issues #757, #601 and #483 where people discuss if this library can support
CBOR
's binary data type. Motivation for this pull request is to discuss how easy it would be to add support for such data type.Binary data type is not natural for
JSON
, but many people have to deal with it, especially, when converting fromCBOR
toJSON
.In
C++
, though, we can represent contiguous binary arrays usingstd::string
,std::vector<uint8_t>
,std::list<uint8_t>
,char*
and whatnot. It could be up to the user how to represent and convert this type intoJSON
.Right now the change is mostly about the API aspect (e.g. adding binary type), without actual implementation.
Comments are very welcome! Thanks!