Using nlohmann::json instead of RapidJson #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
approved these changes
Dec 7, 2017
|
why do we need libcbor? I thought the whole point was to remove it completely as well |
parsifal-47
suggested changes
Dec 8, 2017
There was a problem hiding this comment.
We still have leaks with libcbor, it is not clear how would we solve them. The original idea was to get rid of both libraries at a time, because nlohmann::json has support for cbor as well. It looks like there is no point to invest our time in libcbor improvements
Can't do it right away nlohmann/json#862. At least, we get a better json library. |
khabinov
force-pushed
the
oleg/nlohmann-json
branch
5 times, most recently
from
4656e4e to
c4a7dd7
Compare
Merged
parsifal-47
approved these changes
Dec 11, 2017
|
ok, sorry, I thought it is possible to replace our cbor library with this one |
khabinov
force-pushed
the
oleg/nlohmann-json
branch
from
c4a7dd7 to
a967c0a
Compare
khabinov
force-pushed
the
oleg/nlohmann-json
branch
from
a967c0a to
a98123c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.