Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 throwing an exception in case dump encounters a non-UTF-8 string #838 #870

Merged
merged 2 commits into from
Dec 13, 2017

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 11, 2017

We had a lot of issues with failing roundtrips (i.e., parse errors from serializations) in case string were stored in the library that were not UTF-8 encoded. This PR adds an exception in this case.

Addresses #838


Pull request checklist

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.8 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

We had a lot of issues with failing roundtrips (i.e., parse errors from serializations) in case string were stored in the library that were not UTF-8 encoded. This PR adds an exception in this case.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.897% when pulling 569d275 on feature/issue838 into 383743c on develop.

As we guarantee proper UTF-8 before, we do not need to cope with it later.
@nlohmann nlohmann self-assigned this Dec 12, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Dec 12, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8419bfb on feature/issue838 into 383743c on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants