Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 throwing an exception in case dump encounters a non-UTF-8 string #838 #870

Merged
merged 2 commits into from
Dec 13, 2017
Merged

💥 throwing an exception in case dump encounters a non-UTF-8 string #838 #870

merged 2 commits into from
Dec 13, 2017

Commits on Dec 11, 2017

  1. 💥 throwing an exception in case dump encounters a non-UTF-8 string #838 

    We had a lot of issues with failing roundtrips (i.e., parse errors from serializations) in case string were stored in the library that were not UTF-8 encoded. This PR adds an exception in this case.
    @nlohmann
    nlohmann committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    569d275 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. ✅ improved test coverage 

    As we guarantee proper UTF-8 before, we do not need to cope with it later.
    @nlohmann
    nlohmann committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    8419bfb View commit details
    Browse the repository at this point in the history