Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebUrl property to Commit #127

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

ap0llo
Copy link
Contributor

@ap0llo ap0llo commented Mar 21, 2020

Issues, Merge Requests and Milestones expose a WebUrl property that contains the link to the GitLab web interface for the item.
The Commit class does not have such a property, but the server response includes it (according to the GitLab API docs)

This PR adds the WebUrl property to the Commit class as well.

The PR also adds a global.json to pin the .NET Core SDK version to 3.1.100 because the build seems to be broken on the recently released SDK 3.1.200 (dotnet/sdk#10878)

@jetersen
Copy link
Collaborator

jetersen commented Apr 9, 2020

@ap0llo mind reverting 9151b30 ? and merge or rebase with master.

@codecov-io
Copy link

Codecov Report

Merging #127 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   71.06%   71.02%   -0.04%     
==========================================
  Files         151      151              
  Lines        2139     2140       +1     
==========================================
  Hits         1520     1520              
- Misses        619      620       +1     
Impacted Files Coverage Δ
...GitLabApiClient/Models/Commits/Responses/Commit.cs 15.38% <0.00%> (-1.29%) ⬇️

@ap0llo
Copy link
Contributor Author

ap0llo commented Apr 9, 2020

@jetersen Sure. I removed 9151b30 and rebased onto master

@jetersen jetersen merged commit c90c235 into nmklotas:master Apr 9, 2020
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants