[SplitLogicalObjFifo] Allow using gcd for computing splitFactor #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- We anyway use gcd for computing splitFactor when split factor has not been explicitly provided/computed. But we error out if the provided split factor doesn't divide source/target size. -- This commit therefore allows replacing the explicitly provided split factor with gcd when the former doesn't divide source/target size. Signed-off-by: Abhishek Varma <abhvarma@amd.com>
Abhishek-Varma
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
jtuyls
as code owners
jtuyls
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- We anyway use gcd for computing splitFactor when split factor has
not been explicitly provided/computed. But we error out if the
provided split factor doesn't divide source/target size.
-- This commit therefore allows replacing the explicitly provided
split factor with gcd when the former doesn't divide source/target
size.
Signed-off-by: Abhishek Varma abhvarma@amd.com