If start or end are instance of Date then format to YYYY-MM-DD #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanov
reviewed
Nov 1, 2019
Contributor
nanov
left a comment
nanov
left a comment
There was a problem hiding this comment.
Great enchainment, I would do it a little more verbose, or alternately drop moment.js dependency as a whole. moment.js is used only to format dates on two places, as we are using rather simple ISO formatting the same can be achieved fairly easily with the standard Date.
| const dateRange = (start, end) => { | ||
| if (start && end) | ||
| if (start && end) { | ||
| if (start instanceof Date) { |
Contributor
There was a problem hiding this comment.
Something like moment(start).isValid() be more generic.
If we drop moment, than something like this:
const startDate = new Date(start);
if (isNaN(startDate)) throw new Error('Invalid start date`);
const formatedStartDate = helperFormatter(startDate);
Contributor
|
Solved with v0.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.