Skip to content

If start or end are instance of Date then format to YYYY-MM-DD #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yagop wants to merge 1 commit into from
Closed

If start or end are instance of Date then format to YYYY-MM-DD #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
'use strict';

const moment = require('moment');

const dateRange = (start, end) => {
if (start && end)
if (start && end) {
if (start instanceof Date) {
Copy link
Contributor

@nanov nanov Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like moment(start).isValid() be more generic.
If we drop moment, than something like this:

const startDate = new Date(start);
if (isNaN(startDate)) throw new Error('Invalid start date`);
const formatedStartDate = helperFormatter(startDate);

start = moment(start).format('YYYY-MM-DD');
}
if (end instanceof Date) {
end = moment(end).format('YYYY-MM-DD');
}
return {
DateRange: {
Start: start,
End: end,
},
};
}

return {};
};
Expand Down