-
Notifications
You must be signed in to change notification settings - Fork 305
Expose the user's permissions through a header #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Good stuff! Would "WAC-Mode" be preferable just to keep it closer to *nix's mode bits? |
|
@csarven The header name was chosen in a discussion with @timbl and @dmitrizagidulin yesterday (see #246). I don't mind the naming either way (although I still think "WAC" is cryptic). |
|
I just realized we want to do |
e7e7911 to
b792b9a
Compare
timbl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the whiteboard we had spaces or commas to separate the modes, to mimic other headers. In this code we have semicolons... was that a conscious decision?
|
Which of these would you prefer? I don't mind either way; I was following what @dmitrizagidulin wrote down of our discussion in #246. |
|
To stick close to convention (like in Web Linking for relation types), probably best to use space as a delimiter. Plus, it is easier to read. |
|
Makes sense! Are the quotes needed? |
|
I think the quotes might make it easier for consumers to tokenise. It can also help to escape characters or have specialised modes or something in the future. |
|
Okay, mandatory quotes it is. |
b792b9a to
250e513
Compare
|
250e513 brings spaces. |
|
Currently on hold because of #552. |
250e513 to
4b6a381
Compare
|
#552 has been merged, so this one is ready for review and merge. |
dmitrizagidulin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been a much-requested feature! Nicely done!
Implements #246 with
WAC-Allow: user="read write append",public="read".