Add caching to ACL #552
Merged
Add caching to ACL #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
referenced
this pull request
Aug 18, 2017
This was referenced Aug 18, 2017
RubenVerborgh
force-pushed
the
feature/cache-acl
branch
from
94301db to
bf912ed
Compare
RubenVerborgh
force-pushed
the
feature/cache-acl
branch
from
bf912ed to
fa23c82
Compare
RubenVerborgh
force-pushed
the
feature/cache-acl
branch
from
62cdcbc to
2e81b07
Compare
Contributor
Author
|
@dmitrizagidulin You might want to have this as a merge commit rather than rebase, in order to keep the commits together. |
Contributor
|
@RubenVerborgh good call, re merge |
lib/acl-checker.js
Outdated
|
|
||
| // Check the resource's permissions | ||
| return this._permissionSet.then(acls => this.checkAccess(acls, user, mode)) | ||
| .catch(err => { |
Contributor
There was a problem hiding this comment.
I think this should be indented? Something like:
return this._permissionSet
.then(acls => this.checkAccess(acls, user, mode))
.catch(err => {
})?
Contributor
Author
There was a problem hiding this comment.
Makes sense, will do. (standard didn't complain; but I'd be the last person to say that it is a good style checker 😉)
Contributor
Author
There was a problem hiding this comment.
Done in bda7426, let me know if more indentation needs adjustments.
Contributor
|
Oh man, great work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid that the same .acl files are read and parsed multiple times per request.