Fix update authentication data #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
fix-update-authentication-data
branch
7 times, most recently
from
f816c10 to
bb0d7fc
Compare
4 tasks
nodece
force-pushed
the
fix-update-authentication-data
branch
4 times, most recently
from
2c87e7c to
c60b95b
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
…ckInitializedBefore` failed (apache#18859)
…matched. (apache#18884) ### Motivation Optimize the method, fast return when AppendIndexMetadataInterceptor is matched. ### Modifications 1. Fast return when when AppendIndexMetadataInterceptor is matched.
…e#17836) ### Motivation When the producer sends messages in multiple threads, the message with the smaller sequence Id can be pushed later than the message with the bigger sequence Id. The `internalSendWithTxnAsync` call `internalSendAsync` Asynchronously when `txn != null` https://github.com/apache/pulsar/blob/aeb4503be59f9a9450dfd47cf5dfcb375735d064/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L409 And the `sendAsync` acquire sequence ID is not included in the synchronized block with `serializeAndSendMessage`. https://github.com/apache/pulsar/blob/aeb4503be59f9a9450dfd47cf5dfcb375735d064/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L490 https://github.com/apache/pulsar/blob/aeb4503be59f9a9450dfd47cf5dfcb375735d064/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L555-L560 For example: We send 4 messages (msg1, msg2, msg3, msg4) to the broker and then the 4 messages may get 4 sequence Id (1, 3, 2, 4) which is not in order due to the logic to get the sequence ID and send the message is not in the same synchronous code block. And then the msg3 with sequence ID 2 will never be persistent successfully. ### Modification Add a method to update `sequenceId` and move the method in the sync code. Via apache#16196 we should update message metadata before computing the message size.
…ned (apache#18843) Signed-off-by: tison <wander4096@gmail.com>
Co-authored-by: tison <wander4096@gmail.com>
… been created yet (apache#18804)
… and load BucketDelayedDeliveryTracker - part6 (apache#17756)
…ting up ssh access fails (apache#19127)
…n even if autoSkipNonRecoverableData=true (apache#19132)
…ioned topic (apache#19013) Co-authored-by: gavingaozhangmin <gavingaozhangmin@didiglobal.com>
…se objects creation (apache#19141)
…rmance of Key_Shared subscription (apache#19167)
…he#19176) ### Motivation In apache#15347, there is a regression where the `subName` needed to be passed to the authorization provider. That PR is not released, so this PR is just cleanup ### Modifications * Pass `subName` for `validateTopicOperationAsync` in `PersistentTopicsBase#internalDeleteSubscriptionForNonPartitionedTopicAsync` ### Verifying this change We should add testing to this part of the code base to prevent future regressions. Issue requesting better testing is added: apache#19183. ### Does this pull request potentially affect one of the following parts: This is not a breaking change. ### Documentation - [x] `doc-not-needed`
…unload in checkNamespaceBundleSplit (apache#16780) Co-authored-by: nicklixinyang <nicklixinyang@didiglobal.com>
…tive (apache#19159) Co-authored-by: gavingaozhangmin <gavingaozhangmin@didiglobal.com>
…pache#19184) ### Motivation When a DLQ producer connects, it creates a subscription when configured to do so. The `subscriptionName` should be passed to the `authorizationProvider` to properly determine authorization. ### Modifications * Pass `initialSubscriptionName` to `isTopicOperationAllowed` method in the `ServerCnx`. ### Verifying this change I am going to work on generic tests to cover this case (and some others) when I do apache#19183. ### Does this pull request potentially affect one of the following parts: This is not a breaking change. ### Documentation - [x] `doc-not-needed` This only impacts users that have subscription level permissions, which are not well documented. We should improve those docs eventually, but there is no need to fix those docs while making this fix. ### Matching PR in forked repository PR in forked repository: michaeljmarshall#11
Co-authored-by: nicklixinyang <nicklixinyang@didiglobal.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
fix-update-authentication-data
branch
from
def9d39 to
357035f
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
that referenced
this pull request
Feb 23, 2024
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.