Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try catch 6.2.0 global persistent exception #49

Closed
wants to merge 7 commits into from
Closed

Try catch 6.2.0 global persistent exception #49

wants to merge 7 commits into from

Conversation

gabrielschulhof
Copy link
Collaborator

Implementation of JSRT exception semantics in V8.

@gabrielschulhof
Copy link
Collaborator Author

Note: I did not include napi_trycatch_new() and napi_trycatch_delete() because they would've been noops, just like with ChakraCore. If we decide we need them, I can include them and define them as empty.

@jasongin jasongin mentioned this pull request Jan 19, 2017
Closed
jasongin

This comment was marked as off-topic.

Sign in to view

jasongin

This comment was marked as off-topic.

Sign in to view

jasongin

This comment was marked as off-topic.

Sign in to view

jasongin

This comment was marked as off-topic.

Sign in to view

jasongin

This comment was marked as off-topic.

Sign in to view

@gabrielschulhof gabrielschulhof self-assigned this Jan 20, 2017
gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this pull request Jan 20, 2017
napi: implement exception handling
5cd6adc 
Re nodejsgh-27
Re nodejsgh-49
@gabrielschulhof gabrielschulhof force-pushed the try-catch-6.2.0-global-persistent-exception branch from 5f1c3c3 to 99d28c6 Compare January 20, 2017 11:39
jasongin

This comment was marked as off-topic.

Sign in to view

@jasongin
Copy link
Member

LGTM. I just had the one minor comment about the latest version.

@jasongin jasongin mentioned this pull request Jan 20, 2017
Merged
gabrielschulhof pushed a commit that referenced this pull request Jan 20, 2017
napi: implement exception handling
7e2cb2f 
The approach taken is that of JSRT. That is, the last exception arising
from calls to NAPI APIs is caught and, if not cleared before control
returns to Javascript, it is re-thrown. This creates a
"Is exception pending?"/"Retrieve exception and clear exception status!"
modus operandi.

Closes #49
@gabrielschulhof gabrielschulhof deleted the try-catch-6.2.0-global-persistent-exception branch January 20, 2017 20:29
jasongin pushed a commit to jasongin/abi-stable-node that referenced this pull request Jan 26, 2017
@jasongin
napi: implement exception handling
2fe8220 
The approach taken is that of JSRT. That is, the last exception arising
from calls to NAPI APIs is caught and, if not cleared before control
returns to Javascript, it is re-thrown. This creates a
"Is exception pending?"/"Retrieve exception and clear exception status!"
modus operandi.

Closes nodejs#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongin jasongin jasongin left review comments

Assignees

@gabrielschulhof gabrielschulhof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielschulhof @jasongin