Try catch chakracore #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
force-pushed
the
api-prototype-chakracore-7.x
branch
from
824d477 to
e2480ba
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Closed
…ning to test/addons-abi
gabrielschulhof
force-pushed
the
try-catch-chakracore
branch
from
8d68a1a to
0c96f22
Compare
gabrielschulhof
pushed a commit
to gabrielschulhof/abi-stable-node
that referenced
this pull request
Jan 20, 2017
Re nodejsgh-27 Re nodejsgh-43 (cherry picked from commit 8d8c17fc3458b70abfd2efcaee97538b49ca3008)
|
Can you move this PR onto the new api-prototype-chakracore-8.x branch? It will greatly simplify the PR, since the new branch restores all the tests cases which had been unintentionally deleted from the chakracore-7.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the try/catch API mentioned in #27 (comment), first porting test/addons-abi and implementing the Makefile modifications necessary to make them run.