Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CODE_OF_CONDUCT.md to Contributor Covenant 2.0 #449

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Dec 5, 2019

Per openjs-foundation/cross-project-council#418, the Foundation is seemingly updating to the Contributor Covenant 2.0.

As far as I know, projects are required to use the Foundation CoC which is currently the Contributor Covenant so I'm just updating our own version of it to match.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having inline text and duplicating the source of truth, could this be a link to the relevant content?

@bnb
Copy link
Contributor Author

bnb commented Dec 5, 2019

@ljharb I've voiced my opinion on that in the past (I'm in favor of maintaining actual text, especially since we currently have all repos pointing to this repo which will then point somewhere else), but if we wanted to we could. This was just intended to update per the status quo.

@ljharb
Copy link
Member

ljharb commented Dec 5, 2019

N redirects lands the user in the same place as N - 1 does :-) but fair, as an update to the status quo this ofc LGTM.

Copy link
Contributor

@ryanmurakami ryanmurakami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 5, 2019 via email

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

The discussion in the issue in the CPC repo and I think the agreement that we came to in that issue was to use a link to a specific sha. If only a small number of projects/places are going to disagree with that recommendation then ok, but if most are we should continue the discussion in that issue. @MylesBorins , @bnb as CPC members can you chime into that thread again.

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

Just a bit worried that we may end up with CPC guidance say X, and then the very first project does something different.

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

For some additional context, the discussion in the CPC issue ( openjs-foundation/cross-project-council#413) Is that we'd

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

I'm ok with this as an update on the status quo, but I do want us to come to agreement on what we'll go going forward.

@bnb
Copy link
Contributor Author

bnb commented Dec 5, 2019

@mhdawson fwiw I do think that what the CPC does and what the individual projects do are distinct concerns, at least in the context of openjs-foundation/cross-project-council#413.

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

@bnb not sure I agree. The in person discussion was around what we'd be recommending to projects and that is what triggered the changes to openjs-foundation/cross-project-council#413 to use a specific hash.

@ljharb
Copy link
Member

ljharb commented Dec 5, 2019

@bnb yes, but the concern about privileging english speakers by only inlining the english version, versus the maintenance cost of inlining every translation, seems pretty broadly applicable.

@bnb
Copy link
Contributor Author

bnb commented Dec 5, 2019

@mhdawson @ljharb please see my comment in openjs-foundation/cross-project-council#413 :)

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

@bnb thanks for jumping into the discussion in openjs-foundation/cross-project-council#413

@jasnell
Copy link
Member

jasnell commented Dec 5, 2019

ping @nodejs/tsc

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bnb
Copy link
Contributor Author

bnb commented Dec 6, 2019

also ping @nodejs/community-committee I suppose :)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

I think this has enough CommComm and TSC approvals so landing.

@mhdawson mhdawson merged commit 2398df7 into master Jan 27, 2020
@mhdawson mhdawson deleted the bnb/update-contributor-covenant branch January 27, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.