-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CoC from Contributor Covenant 1.4 to 2.0 #418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need approval from every member project first?
FWIW Node.js will need to update its code of conduct too - I can PR this change: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I personally think we might want to consider having the full text here. Good not to force folks to go to a third party we have no control over for this. |
Rebased to account for #413 being merged. The upstream CoC v2.0 is now inlined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with inline content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Version 2.0 of our upstream code of conduct, the Contributor Covenant, has been released. The project's changelog has not (yet) been updated, but by manual comparison the update appears to bring two major updates:
All other changes appear to be superficial.
This PR updates our references to "v1.4.1" of the Contributor Covenant to refer to its "v2.0" instead. The covenant claims to follow semver, but does not appear to actually publish enumerated patch releases separately; hence dropping the patch number.
This PR is related to #413, which makes our references to the covenant's version more explicit. If/once one of these is merged, the other will need to be amended.