Install of Rscript on new benchmarking machines

[gareth-ellis]

Hello,

Now that two machines have been donated for benchmarking, I've merged a script that was written a while ago for evaluating the impact of a PR on a subset of benchmarks. I've started putting something together in jenkins, however the script makes use of Rscript which will need installing on the two new servers.

The build issue for the machine was #791 and the task in benchmarking was nodejs/benchmarking#58

There's instructions in the benchmarking guide here: https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md

It seems the new machines run ubuntu, so I think this should work:

Add "deb https://cran.us.r-project.org/bin/linux/ubuntu xenial/" to /etc/apt/sources.list

sudo apt-get update
sudo apt-get install r-base r-base-dev

Then install two required packages through the R repl

R
install.packages("ggplot2", repo="http://cran.us.r-project.org")
install.packages("plyr", repo="http://cran.us.r-project.org")

Thanks!

@mhdawson fyi

[AndreasMadsen]

I suppose ggplot2 could be made optional since we are not making any figures. But right now I think it is a requirement.

[gareth-ellis]

Anyone in @nodejs/build who could take care of this? (I am assuming I'm opening this in the right place....please let me know if I've opened this in the wrong place... :) )

[rvagg]

OK, I've done this manually on both servers, but this really needs to be automated in our ansible scripts (see ansible directory) so if someone could try and take care of that it'd be greatly appreciated. This work seems pretty good and would cover all of these tasks fairly simply I think: https://github.com/Oefenweb/ansible-r, otherwise it could be used as a base, or the following could just be hardcoded as shell executions:

echo "deb https://ftp.heanet.ie/mirrors/cran.r-project.org/bin/linux/ubuntu xenial/" > /etc/apt/sources.list.d/r.list
apt-get update
apt-get install r-base r-base-dev -y
echo 'install.packages("ggplot2", repo="http://cran.us.r-project.org")' | R --no-save
echo 'install.packages("plyr", repo="http://cran.us.r-project.org")' | R --no-save

Crossing fingers that this is all that's required. There's a hefty amount of packages in there!

[refack]

I've asked a friend who is an R maven to port compare.R to node, but it'll take some time + the PR cycle.

[AndreasMadsen]

@refack have some concerns about that. There should be an open pull request about it, where I've commented on some of the issues.

I'm on mobile so I can't find it for you, sorry.

[refack]

I'm on mobile so I can't find it for you, sorry.

I'll look it up.

[refack]

nodejs/node#7094?
Found it nodejs/node#12585

[mhdawson]

I was out on holiday. @rvagg was the only option to install on the machine itself. It at all possible I would have preferred that the job do the install to a temporary directory but I understand that is not always possible.

[refack]

Has this been resolved?