Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible scripts needed for Benchmark Machines #868

Closed
mhdawson opened this issue Sep 7, 2017 · 8 comments
Closed

Ansible scripts needed for Benchmark Machines #868

mhdawson opened this issue Sep 7, 2017 · 8 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 7, 2017

We need numpy, requests, eventlet installed on the benchmark marching to let us run DC-EIS.

I've given @uttampower an ansible introduction and he is going to start working on scripts for the benchmarking machines. The first thing they will add to the configuration is these there modules.

In the mean time I've manually added them by running

apt-get update
apt-get install python-pip
apt-get install python2.7-dev

pip install numpy
pip install requests (reports as already satisfied)
pip install eventlet
@rvagg
Copy link
Member

rvagg commented Sep 8, 2017

I'm OK with pip if we must have it, but often the popular packages are available via apt anyway, in this instance python-numpy, python-requests and python-eventlet all seem to be available in both 2.7 and 3 form.

@gibfahn
Copy link
Member

gibfahn commented Sep 8, 2017

I'm OK with pip if we must have it, but often the popular packages are available via apt anyway, in this instance python-numpy, python-requests and python-eventlet all seem to be available in both 2.7 and 3 form.

We're hopefully moving to tap2junit at some point, and I don't think that'll be available on apt (and yum etc.).

@mhdawson mhdawson changed the title Add pip Add pip modules to benchmark machines Sep 8, 2017
@mhdawson
Copy link
Member Author

mhdawson commented Sep 8, 2017

@rvagg

so they can be installed with apt-get ie

apt-get install python-numpy
apt-get install python-request
apt-get install python-eventlet

?

I had used pip as I believe it was already going to be available due to the need for tap2junit but when we work on the ansible scripts we can install the apt packages instead if they are available.

@rvagg
Copy link
Member

rvagg commented Sep 8, 2017

Ah, well if we're using pip already then I guess it comes down to updating. apt-get is often run manually by myself and maybe others on our test machines but that's all for updating. If there's a pip update process it's unlikely to ever be run. Is that a problem? I don't know! I feel like this is one for the python folks among us to answer.
Sorry for the non-answer, my preference is still for apt-get install (apt-get install python-numpy python-request python-eventlet -y) but it's no big deal if we do it with pip I guess.

@gibfahn
Copy link
Member

gibfahn commented Sep 8, 2017

I'd prefer using apt where available too FWIW.

It would make sense to periodically rerun our ansible scripts (once we have them set up) to update everything.

@mhdawson mhdawson changed the title Add pip modules to benchmark machines Ansible scripts needed for Benchmark Machines Nov 28, 2017
@mhdawson
Copy link
Member Author

@uttampower have you had a chance to start working on this yet ?

@maclover7
Copy link
Contributor

Related issues: #821, #955

@mhdawson
Copy link
Member Author

Related issue #1147

maclover7 added a commit to maclover7/build that referenced this issue Mar 7, 2018
maclover7 added a commit to maclover7/build that referenced this issue May 28, 2018
Fixes: nodejs#868
Fixes: nodejs#1147

Creates a new `benchmarking` Ansible role, and runs for all machines
with the `is_benchmark` machine variable set to `true`.

Included `infra-softlayer-ubuntu1404-x64-2` since it is also a benchmark
machine, in addition to `test-nearform_intel-ubuntu1604-x64-1` and
`x64-2`.
maclover7 added a commit that referenced this issue May 31, 2018
Fixes: #868
Fixes: #1147

Creates a new `benchmarking` Ansible role, and runs for all machines
with the `is_benchmark` machine variable set to `true`. Installs `h2load` utility package.

Included `infra-softlayer-ubuntu1404-x64-2` since it is also a benchmark
machine, in addition to `test-nearform_intel-ubuntu1604-x64-1` and
`x64-2`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants