Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: run win32 CI on Node.js 19 #2927

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

richardlau
Copy link
Member

Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18.

Introduce a new gteLt closure for exclusions between two versions.

Refs: nodejs/node#42690
Refs: nodejs/node#42740 (comment)
Refs: #2921

Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18.

Introduce a new `gteLt` closure for exclusions between two versions.

Refs: nodejs/node#42690
Refs: nodejs/node#42740 (comment)
Refs: #2921
@richardlau
Copy link
Member Author

Note, this will have no affect on the CI runs until Node.js 18 is released and the version on the master branch of https://github.com/nodejs/node bumped up to Node.js 19(.0.0-pre).

@targos
Copy link
Member

targos commented Apr 19, 2022

@nodejs/build

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 5e2ae08 into master Apr 19, 2022
@richardlau richardlau deleted the run-win32-on-nodejs19 branch April 19, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants