Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: replace DO ubuntu1604-x86 hosts with ubuntu2204-x64 #3561

Merged
merged 2 commits into from
Nov 7, 2023
Merged

ansible: replace DO ubuntu1604-x86 hosts with ubuntu2204-x64 #3561

merged 2 commits into from
Nov 7, 2023

Conversation

targos
Copy link
Member

@targos targos commented Nov 6, 2023 •
edited
Loading

Refs: #3317

@targos
Copy link
Member Author

targos commented Nov 6, 2023

This is still work-in-progress.

targos
targos commented Nov 6, 2023
View reviewed changes
ansible/roles/baselayout/vars/main.yml
ubuntu2204: [
'gcc,g++,python2,python3,python-is-python3',
'gcc,g++,python3,python-is-python3',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need python2 anymore, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. In theory just Python 3 should work. I'm not even sure we need python-is-python3.

@targos
Copy link
Member Author

targos commented Nov 6, 2023

Hosts are online:
https://ci.nodejs.org/computer/test%2Ddigitalocean%2Dubuntu2204%2Dx64%2D1/
https://ci.nodejs.org/computer/test%2Ddigitalocean%2Dubuntu2204%2Dx64%2D2/

@targos
Copy link
Member Author

targos commented Nov 6, 2023

Some CI runs:

@targos
Copy link
Member Author

targos commented Nov 6, 2023

Trying again as rebuilds of https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/33413/

@targos
Copy link
Member Author

targos commented Nov 7, 2023

Jobs are green!

@targos targos marked this pull request as ready for review November 7, 2023 07:30
@ovflowd
Copy link
Member

ovflowd commented Nov 7, 2023

Jobs are green!

🎉

What are the next steps?

@targos
Copy link
Member Author

targos commented Nov 7, 2023

Reviews :)

@targos targos merged commit 74df2d1 into nodejs:main Nov 7, 2023
1 check passed
@targos targos deleted the do-ubuntu2204 branch November 7, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @ovflowd @richardlau