Missing or unselected GCC 10 on many hosts - Blocks V8 updates!

[targos]

Easy to spot because GCC 8 and 9 don't support -std=gnu++20

Latest C++20 CI: https://ci.nodejs.org/job/node-test-pull-request/56278/

Things remaining to update:

• Debian
• Ubuntu 18.04
  • Ubuntu 18.04 sharedlib containers
• https://ci.nodejs.org/label/ubi81_sharedlibs_openssl111fips_x64/
• armv7l (despite Ubuntu 20.04)

[targos]

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/ runs on the
ubuntu1804-64 label.
One option could be to use an ubuntu2004 or ubuntu2204 label.

[targos]

@nodejs/build. I pinned this issue.

The OP summarises what needs to be updated. It may be a small list, but it includes a large part of our CI hosts.

[richardlau]

• armv7l (despite Ubuntu 20.04)

Ah this one is because the select-compiler changes we made were to the section where "$SELECT_ARCH" = "ARM64" which won't be true for armv7l. I think my preference is to work towards adding x64 Ubuntu 20.04 into the test CI matrix and then move the compiler selection for Ubuntu 20.04 so that it is not architecture specific.

[targos]

Just found that https://ci.nodejs.org/label/ubi81_sharedlibs_openssl111fips_x64/ are still on GCC 8

[targos]

^ @anonrig is looking into it.

[targos]

Chromium now officially supports C++20: https://chromium-review.googlesource.com/c/chromium/src/+/4217486

[targos]

Adding build agenda for awareness. This is now blocking further V8 upgrades.

[targos]

We need to select the right compiler on ubi81: https://ci.nodejs.org/job/node-test-commit-linux-containered/40782/nodes=ubi81_sharedlibs_openssl111fips_x64/console

@richardlau Can you help with that?

[richardlau]

We need to select the right compiler on ubi81: https://ci.nodejs.org/job/node-test-commit-linux-containered/40782/nodes=ubi81_sharedlibs_openssl111fips_x64/console

@richardlau Can you help with that?

Opened #3590

[targos]

We're close!

I think this one just needs another update to select-compiler.sh?

https://ci.nodejs.org/job/node-test-commit-arm/50418/nodes=ubuntu2004-armv7l/console

[richardlau]

We're close!

I think this one just needs another update to select-compiler.sh?

https://ci.nodejs.org/job/node-test-commit-arm/50418/nodes=ubuntu2004-armv7l/console

Yes, I think so. gcc-10 should be available

build/ansible/roles/docker/templates/ubuntu2004_armv7l.Dockerfile.j2

Lines 19 to 20 in e2440ff

	g++-10 \
	gcc-10 \

It looks like currently select-compiler.sh isn't aware of armv7l so it doesn't actually select anything (i.e. leaves things as default)

build/jenkins/scripts/select-compiler.sh

Lines 19 to 26 in e2440ff

	case $NODE_NAME in
	*ppc64*le* ) SELECT_ARCH=PPC64LE ;;
	*s390x* ) SELECT_ARCH=S390X ;;
	*aix* ) SELECT_ARCH=AIXPPC ;;
	*x64* ) SELECT_ARCH=X64 ;;
	*arm64* ) SELECT_ARCH=ARM64 ;;
	*ibmi73* ) SELECT_ARCH=IBMI73 ;;
	esac

[targos]

select-compiler.sh was not run in https://ci.nodejs.org/job/node-test-binary-armv7l/9214/RUN_SUBSET=native,nodes=ubuntu2004-armv7l/console

[targos]

@richardlau is this the correct fix, in https://ci.nodejs.org/job/node-test-binary-armv7l/configure:

[richardlau]

@targos Yes, that looks good.

[targos]

Done!

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/56278/

[targos]

I believe this is done 🎉