Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: enable select-compiler.sh on UBI8 #3590

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

richardlau
Copy link
Member

Refs: #3317 (comment)


This needs a corresponding change in node-test-commit-linux-containered to call select-compiler.sh on the ubi81_sharedlibs_openssl111fips_x64 configuration.

e.g. Insert the following at the top of the script:

export CCACHE_BASEDIR=$PWD
curl -sLO https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/select-compiler.sh
. ./select-compiler.sh

Test build using select-compiler.sh from main (still defaults to gcc 8 as it falls through all conditionals):

Test build showing GCC 10 is picked (using the modified select-compiler.sh from this PR):

Test build for https://github.com/targos/node/tree/c%2B%2B20:

cc @targos

@richardlau
Copy link
Member Author

This needs a corresponding change in node-test-commit-linux-containered to call select-compiler.sh on the ubi81_sharedlibs_openssl111fips_x64 configuration.

e.g. Insert the following at the top of the script:

export CCACHE_BASEDIR=$PWD
curl -sLO https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/select-compiler.sh
. ./select-compiler.sh

Test build using select-compiler.sh from main (still defaults to gcc 8 as it falls through all conditionals):

* https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/23/nodes=ubi81_sharedlibs_openssl111fips_x64/consoleFull

Since the test build showed there's no harm in calling the current select-compiler.sh script from main (i.e. the script is called but no change in compiler occurs without the changes in this PR) I've made the change to the ubi81_sharedlibs_openssl111fips_x64 configuration. The job should then pick up the changes from this PR when it is merged into main.

@targos targos merged commit 02a6a45 into main Dec 11, 2023
4 checks passed
@targos targos deleted the ubi8-select-compiler branch December 11, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants